Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Book clubs and user permissions #186

Merged
merged 17 commits into from
Nov 4, 2023
Merged

Conversation

aaronleopold
Copy link
Collaborator

@aaronleopold aaronleopold commented Oct 28, 2023

This rather massive PR does a lot, and there are very likely breaking changes, but I'll overview the highlights below:

  • Development towards the book club features [FEATURE] Book club features #120 (WIP)
    • API is exposed, but UI is hidden. I cannot promise hard breaking changes to the DB structure wrt this feature won't be made after this PR, since I will be merging before it reaches a viable state, so if you bypass the hidden UI elements or interact with the API directly it is at your own risk. So long as you don't create a book club, it should be fine (👀)
  • Created new rust app for handling all of the code generation
    • This was a well needed chore, was a bit of a hassle managing two type exports and Prisma client generation
    • Merged generated TypeScript types now go to a single generated.ts file
  • Development towards a proper user permission model, where the server owner can grant various permissions to any given account RBAC / ABAC for managed accounts #41
    • Note that this won't really be an RBAC model, as roles aren't really required here. The trade off is a little verbosity for more granular control
  • Small updates to the file explorer UI
  • New Calendar and DatePicker components to support book club features

There is still a bit more work to get through wrt the permissions, but I'll aim to wrap it up and merge this either this or next weekend

User update/creation form

🚧 Breaking changes

Mainly server_preferences table was renamed to server_config. Once I start versioning Stump, I'll take more care in the migrations to not let a change like this break anything. The worst that should happen would be your job scheduler config needs to be recreated

@aaronleopold aaronleopold marked this pull request as ready for review November 4, 2023 20:57
@aaronleopold aaronleopold changed the title [WIP] 🚧 Book clubs and user permissions 🚧 Book clubs and user permissions Nov 4, 2023
@aaronleopold aaronleopold merged commit c9571a3 into develop Nov 4, 2023
7 checks passed
@aaronleopold aaronleopold deleted the al/book-clubs-and-rbac branch November 4, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant