Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Select custom thumbnails #167

Merged
merged 6 commits into from
Oct 1, 2023
Merged

✨ Select custom thumbnails #167

merged 6 commits into from
Oct 1, 2023

Conversation

aaronleopold
Copy link
Collaborator

@aaronleopold aaronleopold commented Sep 29, 2023

Resolves #166

PR adds logic to pick a page from a book to use as the thumbnail for itself of its associated series/library. After the initial release, I'll be sure to refactor this implementation to be more resilient against regeneration (e.g. so you don't have to manually select your override whenever you force-regenerate thumbnails)

For media and series, they are getting their own new management pages. Rather than adding a bunch of modals for future features, e.g. metadata management, all similar items will live there. For library thumbnails, it will go in the existing library management page.

Note that EPUB files won't be supported for this feature at this time. In the future, it could be possible to extend this to query for all image resources inside the EPUB and select from that, but I don't want to prioritize figuring that out now.

@aaronleopold aaronleopold marked this pull request as ready for review October 1, 2023 23:25
@aaronleopold aaronleopold changed the title [WIP] ✨ Select custom thumbnails ✨ Select custom thumbnails Oct 1, 2023
@aaronleopold
Copy link
Collaborator Author

I'm going to eagerly merge this after it passes CI again, there is a bit of duplication for some of the UI logic, and it doesn't look perfect IMO, but I'll tackle that another day so I can focus on other non-UI things for now.

This PR was adjusted to also add a fix for an unsafe unwrap, and the order_by clause that was missing on thumbnail API calls. Regarding the first one, before a release I should do a search and replace for all of the old unwraps that might be left from when I first started the project 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant