-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ support filtering and basic search #152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also to note, I forgot about sorting 🙈 the server supports it but I got so wrapped up in filtering that sorting slipped my mind. I'll make a follow-up PR sometime in the coming weeks to quickly add that in. |
Also also, found this and love it so will adopt it (maybe) https://gitmoji.dev/ |
aaronleopold
changed the title
[DRAFT] support filtering and basic search
✨ support filtering and basic search
Sep 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally added a good foundation for filtering and searching within the UI! The search is really naive at the moment, I can't implement a full text search until Prisma supports it for SQLite, but I think for the time being this is more than enough. It also doesn't look great on mobile ATM, but OK for now.
Screenshots