Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RAR support (fix Windows) #138

Merged
merged 7 commits into from
Jun 5, 2023
Merged

feat: RAR support (fix Windows) #138

merged 7 commits into from
Jun 5, 2023

Conversation

aaronleopold
Copy link
Collaborator

Moved off of my old (bad) in-place byte reading implementation and using the WIP 0.5 feature branch from the upstream unrar.rs. I had to make a few adjustments to get things compiling, but you can see the fork here

So far, tested on Windows and macOS. I will test Linux and Docker over the weekend 👏

@aaronleopold
Copy link
Collaborator Author

Soooo it seems to be working on macOS, Windows, and Linux when running from source. Docker still throws a seg fault when inline-reading bytes, however 😭

I'm inclined to merge this AS-IS, since it is better than it was as far as RAR support goes, but I don't want to dive too hard into C++ world right now to try and debug what is going on in Docker with unrar.rs. Conversions (which requires extracting the RAR files FULLY) also throws a seg-fault. So, I am not necessarily feeling this is necessarily an inline-reading problem anymore. I think the next steps once I have time might be to create an isolated Rust app with unrar.rs and run it in a docker container to see when and how it breaks.

@aaronleopold aaronleopold changed the title [WIP] feat: RAR support feat: RAR support (add Windows) Jun 3, 2023
@aaronleopold aaronleopold changed the title feat: RAR support (add Windows) feat: RAR support (fix Windows) Jun 3, 2023
@aaronleopold aaronleopold merged commit 49b3db5 into develop Jun 5, 2023
@aaronleopold aaronleopold deleted the al/rar-support branch June 5, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant