feat: epub progress tracking #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stump now has minimal abilities for tracking the progress of EPUB reading, granted it is a bit scuffed.
epubjshas not made this very easy... I extract the currentepubcfias a user reads, so that the next session properly navigates to the appropriate point in the book, and then I have a percentage approximation. Both of these operations are calculated in this rather gross effect. There was no (functional) means for me to calculate the percentage from theepubcfiusingepubjs, and so I came up with the following:The obvious issue is not all chapters are of the same size, but since I have no other means of extracting this information from epubjs, this will have to do for now. FWIW, I tested about 10 books and I never was more than 1.5% off at the end of the book (i.e. 98.5% instead of the true 100%).
I also cleaned up a couple of the OPDS endpoints, and added the download OPDS endpoint for media files.