Navigation fixes #108
Navigation fixes #108
Conversation
- buttons now mimic native browser navigation buttons. - disabled in the browser, native navigation buttons should be used instead.
| const ServerConnectionError = lazily(() => import('./pages/ServerConnectionError')) | ||
| const LoginOrClaim = lazily(() => import('./pages/LoginOrClaim')) | ||
| const OnBoarding = lazily(() => import('./pages/OnBoarding')) | ||
| const Home = lazily(() => import('./pages/Home.js')) |
There was a problem hiding this comment.
Fixed some tedious lint errors in AppRouter
I assume adding .js was part of this? What was the lint?
There was a problem hiding this comment.
Yes it was, also for some reason anything but 'js' would trigger an error as well.
Can't remember what the linter was, I'll let you know in the morning it's 11:30pm here and I'm done with code for the day 😅
There was a problem hiding this comment.
Huh, interesting - alright. I was worried those changes wouldn't bundle properly since those files with .js don't technically exist, but locally building it seems to have properly picked it up so 🤷
Can't remember what the linter was, I'll let you know in the morning it's 11:30pm here and I'm done with code for the day 😅
Haha no worries, have a good night!
There was a problem hiding this comment.
Nice, with this I can finally get rid of this store, as it won't be used after al/bye-chakra gets merged
| @@ -91,7 +91,10 @@ function EpubHeaderControls({ | |||
| align="flex-start" | |||
| > | |||
| <ButtonGroup isAttached> | |||
| <IconButton variant="ghost" onClick={() => navigate(`/books/${epub.media_entity.id}`)}> | |||
| {/* FIXME: This navigate(-3) is effectively going back three times. | |||
There was a problem hiding this comment.
Thanks for noting this!
Fixes #45
A couple of extra fixes that felt natural at that point:
backwardUrlandforwardUrlbecause it looked like they weren't needed anymore.books/idAppRouter