Skip to content

Commit

Permalink
💚 Fix runs-on for docker build workflows (#407)
Browse files Browse the repository at this point in the history
* 💚 Fix `runs-on` for docker build workflows

* disable caching for docker action
  • Loading branch information
aaronleopold authored Aug 20, 2024
1 parent 4cdf471 commit afd42e9
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 12 deletions.
4 changes: 4 additions & 0 deletions .github/actions/build-docker/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ runs:

- name: Setup rust
uses: ./.github/actions/setup-rust
with:
# Note: until some sort of local caching is implemented, we don't want to cache dependencies
# because the network overhead is too high and eats up lots of time
cache-dependencies: ${{ runner.name != 'oromei-ubuntu' }}

# We only need QEMU when an arm* platform is targeted
- name: Check QEMU requirement
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,6 @@ jobs:
if: "!contains(github.event.pull_request.head.ref, 'release/v') && needs.code-changes-check.outputs.rust-changed == 'true'"
name: Rust checks
runs-on: [self-hosted]
# TODO: investigate if this would work and if it would be worth...
# runs-on: ${{ matrix.os }}
# strategy:
# matrix:
# os: [self-hosted-linux, windows-latest]
# include:
# - os: self-hosted-linux
# runner: self-hosted
# - os: windows-latest
# runner: windows-latest
steps:
- name: Checkout repository
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/experimental.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
nightly-docker-build:
needs: code-changes-check
name: Build docker image
runs-on: [ubuntu-22.04]
runs-on: [self-hosted]
if: ${{ needs.code-changes-check.outputs.changes != '[]' }}
steps:
- name: Checkout repository
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
needs: code-changes-check
if: "!contains(github.event.pull_request.head.ref, 'release/v') && needs.code-changes-check.outputs.changes != '[]'"
name: Build docker image
runs-on: [ubuntu-22.04]
runs-on: [self-hosted]
steps:
- name: Checkout repository
uses: actions/checkout@v3
Expand Down

0 comments on commit afd42e9

Please sign in to comment.