Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Add link to helper article in version control notice #190

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

mike-day
Copy link
Contributor

@mike-day mike-day commented Jun 2, 2023

Tasks

Summary of changes

This PR adds a link to a new helper article about setting up version control for a WordPress theme.

Related Issues

How to test

  1. Switch to a theme that has not had the version control notice dismissed (or delete thepatternmanager_version_control_notice_dismissed_themes DB entry from usermeta)
  2. Confirm that a link is displayed in the version control notice
  3. Confirm that the link works

Notes & Screenshots

Screenshot 2023-06-02 at 9 33 15 AM

@mike-day mike-day self-assigned this Jun 2, 2023
@mike-day
Copy link
Contributor Author

mike-day commented Jun 2, 2023

Is it preferable for the link to open in a new tab? Currently, the article opens in the same tab.

@kienstra
Copy link
Contributor

kienstra commented Jun 2, 2023

Is it preferable for the link to open in a new tab? Currently, the article opens in the same tab.

Yeah, that'd probably be better. It's to an external URL.

{ __(
'No version control detected for this theme. We recommend adding version control so you do not lose your patterns during theme updates.',
'pattern-manager'
{ createInterpolateElement(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of createInterpolateElement()

Copy link
Contributor

@kienstra kienstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mike-day,
This looks really good, nice createInterpolateElement() use.

Screenshot 2023-06-02 at 2 57 54 PM

@mike-day
Copy link
Contributor Author

mike-day commented Jun 6, 2023

Is it preferable for the link to open in a new tab? Currently, the article opens in the same tab.

Yeah, that'd probably be better. It's to an external URL.

This is covered with e203a67.

@mike-day mike-day merged commit fc4298c into main Jun 7, 2023
@mike-day mike-day deleted the add/version-control-helper-article branch June 7, 2023 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants