This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Fix pattern preview heights when on a row by themselves #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Summary of changes
When a pattern preview is by itself, it takes up 100% of the height available. This PR makes it so that it shrinks down to 300px, while still allowing a longer pattern to show its full height.
Before:
After:
Note: this also affects how short patterns show beside long patterns:
Before:
After:
I spoke with Kam about this and confirmed that while a masonry layout might be preferable, we can iterate to that later if needed.
How to test