-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Web hosted documentation #63
Conversation
Just sharing first feelings... 793 files changed easily... 🧩 |
@cejanen I know 😅, but It's mostly generated files for the static web docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I haven't read all texts but "smekam". I don't know if you used any special tool to generate those texts specially to showcase usage of classes but respect.
So far I'm just curious why do we remove readme file?
Another question. Can I test somehow that the docs will work as expected before merging and updating repo settings as described in PR notes.
Thank you for the kind words 🙏. No I didn't use any tool to generate the usage documentation. You can test the documentation by running
It will start a local preview server with the documentation. |
@matejmolnar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanna see it live 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes a lot 🙇 . Few comments 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come that for example TCA doesn't have all of those CSS/JS files 🤔 😄 ? Do you know how can that be achieved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some projects use a special branch which includes just the documentation, so that's what I though they were doing as well. But upon a closer inspection I found out that it's not the case, but they are actually using Jekyll to build the documentation in a github action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, interesting.
They also have the custom branch: https://github.com/pointfreeco/swift-composable-architecture/tree/gh-pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch, how did you find it? 😄 So yeah that's how they do it and they also use Jekyll on top. When I was talking to @cejanen about the separate branch, he said to not worry about it for now and just put the docs into the master branch. But yeah once we would like to also keep multiple versions of the documentation a separate branch is the way to go 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love if we could have the docs hidden elsewhere (eg. in the separate branch), but this is more than enough
This PR aims to solve this ticket
generate_docs.sh
script file for generating static web documentation filesdocumentation.md
/README.md