[feat] Users screen with more samples #54
Conversation
0d068f8 to
b109b4c
Compare
NetworkingSampleApp/NetworkingSampleApp/Scenes/Users/UsersViewModel.swift
Show resolved
Hide resolved
| import Networking | ||
|
|
||
| @MainActor | ||
| final class UsersViewModel: ObservableObject { |
There was a problem hiding this comment.
@matejmolnar @cejanen Why do we sometimes use a service as well in the VMs and sometimes we don't?
Eg. the upload also has a UploadService 😅
There was a problem hiding this comment.
Usually for samples we don't. For samples we try to keep code as simple as possible just to showcase the library usage. Because upload service logic is shared in multiple VMs it made sense to extract it own service class.
There was a problem hiding this comment.
Although I am still not entirely sure why is the UploadAPIManager implementation so different and more complex than the DownloadAPIManager 🤔 but that's a topic for another debate 😄
There was a problem hiding this comment.
you can suggest simplification for sure!
There was a problem hiding this comment.
@matejmolnar I think that was my first comment and conclusion on the Upload PR as well, that it could have been almost 1:1 with the download manager.
| import Networking | ||
|
|
||
| @MainActor | ||
| final class UsersViewModel: ObservableObject { |
There was a problem hiding this comment.
you can suggest simplification for sure!
NetworkingSampleApp/NetworkingSampleApp/Scenes/Users/UsersViewModel.swift
Show resolved
Hide resolved
8c0ac75 to
b7565d2
Compare
This pull request is aiming to solve issue #39
Changes
SampleUserRouter.responseDecoderdue to thedateDecodingStrategy.Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-12-11.at.14.53.07.mp4