Guids for replicated models #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| deprecated('The model ' + this.modelName + ' is tracking changes, ' + | ||
| 'which requries a string id with GUID/UUID default value.'); | ||
| } | ||
|
|
||
| Change.attachTo(this.dataSource); |
There was a problem hiding this comment.
Shall I rewrite it as !(id.Prop.defaultFn === 'uuid' || id.Prop.defaultFn === 'guid')?
|
Ouch, |
|
Fixed, the patch depends on loopbackio/loopback-datasource-juggler#473 now. @ritch LGTY now? |
3 tasks
|
LGTM |
4f7d6b0 to
f2c5af4
Compare
added 2 commits
March 2, 2015 18:16
Print a deprecation warning when a persisted model is tracking changes but does not have a client-generated unique string id property (GUID).
Fix all test models that are tracking changes so that they have a generated unique string id. Make model names unique where possible to prevent tests reusing the same model which causes unintented side effects.
f2c5af4 to
f21b29e
Compare
bajtos
added a commit
that referenced
this pull request
Mar 2, 2015
…-models Guids for replicated models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #981
/to @ritch please review. I decided to use soft deprecation warning instead of throwing an exception. This way we are not breaking backwards compatibility and make the upgrade process easier (IMO).