Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing timeouts for linter tests #429

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

gracegoo-stripe
Copy link
Contributor

@gracegoo-stripe gracegoo-stripe commented Nov 9, 2021

r? @etsai-stripe

These tests have been intermittently failing due to timeouts: https://github.com/stripe/vscode-stripe/runs/4121204401?check_suite_focus=true

The open and show document functions can take a couple of seconds in the worst case scenario which will cause the test to timeout (the default is 2 seconds). Even for ones that do pass, we always come close to the timeout in the first two test cases.

See logs added here: https://github.com/stripe/vscode-stripe/runs/4159081815?check_suite_focus=true.

Doc open took: 245 ms
Doc show took: 126 ms
Test set up took 374 ms
Linter construction took 1 ms
File is ignored by git? true
Linter.activate took  2 ms
Test cleanup  1 ms
      ✔ Editor content is not searched when file is git-ignored (379ms)

These tests have been intermittently failing due to timeouts.
The open and show document functions can take a couple of seconds in the worst case scenario
which will cause the test to timeout
@gracegoo-stripe gracegoo-stripe merged commit 1e6d3c8 into master Nov 10, 2021
@gracegoo-stripe gracegoo-stripe deleted the gracegoo-lint-testing branch November 10, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants