Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-6839: refactor and add tests #386

Merged
merged 13 commits into from
Oct 20, 2021
Merged

Conversation

etsai-stripe
Copy link
Contributor

@etsai-stripe etsai-stripe commented Oct 15, 2021

https://jira.corp.stripe.com/browse/DX-6839

clean up prototype code and add tests

Java Server connection error/exception handled and shown in client IDE
Screen Shot 2021-10-19 at 5 03 41 PM

Copy link
Contributor

@gracegoo-stripe gracegoo-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! I have some small questions

src/stripeJavaLanguageClient/javaServerStarter.ts Outdated Show resolved Hide resolved
src/stripeJavaLanguageClient/javaServerStarter.ts Outdated Show resolved Hide resolved
src/stripeJavaLanguageClient/javaServerStarter.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@gracegoo-stripe gracegoo-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for making all those changes!

@etsai-stripe etsai-stripe merged commit 9179553 into etsai/javaLsp Oct 20, 2021
@etsai-stripe etsai-stripe deleted the etsai/javaLspTests branch October 20, 2021 18:36
etsai-stripe added a commit that referenced this pull request Oct 20, 2021
* DX-6802: download and extract jdt server (#377)

* Java Lang Server Prototype (#383)

* DX-6795: java server prototype (WIP)

* wip

* wip

* wip

* wip

* wip

* java lang server prototype

* lint fix

* update extension dependency

* bug fixes

* DX-6839: refactor and add tests (#386)

* DX-6839: refactor and add tests

* wip

* language client tests

* stripe hover provider tests

* add code reference comments

* fix lint

* execute parameters tests

* check package json file

* fix tests

* remove hardcoded jar path

* fix test

* handle errors and telemetry

* address comments

* DX-6804: auto update jdt server version (#389)

* DX-6804: get latest jdt server version

* remove latest version text file

* move jdt server to distributed folder for release

* update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants