-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DX-6839: refactor and add tests #386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! I have some small questions
gracegoo-stripe
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for making all those changes!
etsai-stripe
added a commit
that referenced
this pull request
Oct 20, 2021
* DX-6802: download and extract jdt server (#377) * Java Lang Server Prototype (#383) * DX-6795: java server prototype (WIP) * wip * wip * wip * wip * wip * java lang server prototype * lint fix * update extension dependency * bug fixes * DX-6839: refactor and add tests (#386) * DX-6839: refactor and add tests * wip * language client tests * stripe hover provider tests * add code reference comments * fix lint * execute parameters tests * check package json file * fix tests * remove hardcoded jar path * fix test * handle errors and telemetry * address comments * DX-6804: auto update jdt server version (#389) * DX-6804: get latest jdt server version * remove latest version text file * move jdt server to distributed folder for release * update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.corp.stripe.com/browse/DX-6839
clean up prototype code and add tests
Java Server connection error/exception handled and shown in client IDE