Do not try to acquire dotnet runtime if we are on M1 macs #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // arm64 is not supported for dotnet < 6.0: | ||
| // https://github.com/dotnet/core/issues/4879#issuecomment-729046912 | ||
| if (getOSType() === OSType.macOSarm) { | ||
| outputChannel.appendLine(`.NET runtime v${dotnetRuntimeVersion} is not supported for M1`); |
There was a problem hiding this comment.
You might want to say Apple Silicon
vcheung-stripe
approved these changes
Jun 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287.
dotnet < 6.0 is not supported for native M1 so this commit adds a check to not even attempt to acquire it.
Given that dotnet is not supported, we don't expect this path to be hit anyway but adding telemetry to get some numbers.
getDotnetProjectFilesand added them back in.