Moving stripe samples to it's own menu #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcheung-stripe
requested changes
Jun 8, 2021
src/stripeSamplesView.ts
Outdated
Comment on lines
17
to
22
| const findSamplesItem = new StripeTreeItem('Find code samples', { | ||
| commandString: 'openSamples', | ||
| iconPath: new ThemeIcon('code'), | ||
| tooltip: 'Sample integrations built by Stripe', | ||
| }); | ||
| items.push(findSamplesItem); |
There was a problem hiding this comment.
Oh apologies if I wasn't clear! The Find code samples link should be available when you right-click the Start with a Stripe Sample link. It involves
- adding a
contextValueto thesamplesItem - registering
stripe.openSamplesin the package.json similar to howstripe.openDashboardEventis registered.
stripe.openDashboardEvent should be a good example of how to do this!
There was a problem hiding this comment.
Ah had no idea this menu existed! I should right click more in VScode
…pe into ctrudeau-move-samples
|
Switched to context menu. Thanks for the suggestion, I had no idea this existed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Manually tested:
fixes #249
r? @vcheung-stripe