Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring sdk-release/next-major up to date #1143

Merged
merged 5 commits into from
Nov 7, 2022
Merged

Bring sdk-release/next-major up to date #1143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2dec63e
Update request_end instrumentation example (#1095)
bdewater Oct 14, 2022
46eca72
Do not run Coveralls if secret token is not available (#1137)
anniel-stripe Oct 24, 2022
c2bb4db
Codegen for openapi v204 (#1138)
kamil-stripe Nov 2, 2022
6dc0095
Disable AsciiComments rule (#1142)
anniel-stripe Nov 2, 2022
7f4fe21
Merge branch 'master' into richardm-next-major
richardm-stripe Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ Style/AccessModifierDeclarations:
EnforcedStyle: inline

Style/AsciiComments:
AllowedChars:
- ’
- €
Enabled: false

Style/FrozenStringLiteralComment:
EnforcedStyle: always
Expand Down
2 changes: 1 addition & 1 deletion OPENAPI_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v184
v204
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,13 @@ For example:

```ruby
Stripe::Instrumentation.subscribe(:request_end) do |request_event|
# Filter out high-cardinality ids from `path`
path_parts = event.path.split("/").drop(2)
resource = path_parts.map { |part| part.match?(/\A[a-z_]+\z/) ? part : ":id" }.join("/")

tags = {
method: request_event.method,
resource: request_event.path.split('/')[2],
resource: resource,
code: request_event.http_status,
retries: request_event.num_retries
}
Expand Down
2 changes: 1 addition & 1 deletion test/test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Report test coverage to coveralls for only one Ruby version to avoid
# repeated builds. This also accounts for coveralls_reborn requiring
# RUBY_VERSION >= 2.5.
if RUBY_VERSION.start_with?("3.1.")
if ENV.key?("COVERALLS_REPO_TOKEN") && RUBY_VERSION.start_with?("3.1.")
require "coveralls"
Coveralls.wear!
end
Expand Down