New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ShadowedRoundedRectangle from RowButton #4567

Draft

porter-stripe wants to merge 4 commits into porter/row-button-pt3 from porter/row-button-pt4

Collaborator

porter-stripe commented Feb 13, 2025 •

edited

Loading

Summary

Only floating needs a shadow rounded rect
The flat styles just need a background color

Motivation

Complete the TODO assigned to myself
Further simplifying RowButton

Testing

Manual
Existing tests

Changelog

N/A


          Remove ShadowedRoundedRectangle from RowButton

0dab0c2

porter-stripe added the embedded label

porter-stripe added 3 commits

February 13, 2025 12:22


          Show selection on shadow rect

6db50b2


          Update testDisabledState@3x.png

846e991


          Don't tint alpha on shadow rect

f7b521d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels