[Connect] Add message handling for closing and mobile inputs. #4563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c768e51 to
237379a
Compare
237379a to
5da48e1
Compare
nschris-stripe
commented
Feb 13, 2025
| case close = "closeButtonPressed" | ||
| } | ||
|
|
||
| struct MobileInputReceivedSender: MessageSender { |
There was a problem hiding this comment.
This will be used in a follow up PR.
5da48e1 to
333fcd6
Compare
333fcd6 to
3189fb1
Compare
|
🚨 New dead code detected in this PR: MobileInputReceivedSender.swift:12 warning: Struct 'MobileInputReceivedSender' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
3189fb1 to
80755dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change provides a way for the connect component to trigger a close event. The new events added are:
Test Plan
Added tests for new events.