Deflake testURLParamsWithCardAndBankFundingSources #4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidme-stripe
previously approved these changes
Feb 11, 2025
mats-stripe
previously approved these changes
Feb 11, 2025
StripePaymentSheet/StripePaymentSheet/Source/Internal/Link/Utils/LinkURLGenerator.swift
Outdated
Show resolved
Hide resolved
4687523
davidme-stripe
previously approved these changes
Feb 11, 2025
mats-stripe
previously approved these changes
Feb 11, 2025
tillh-stripe
previously approved these changes
Feb 11, 2025
| @@ -50,7 +50,7 @@ struct LinkURLParams: Encodable { | |||
| var intentMode: IntentMode | |||
| var setupFutureUsage: Bool | |||
| var cardBrandChoice: CardBrandChoiceInfo? | |||
| var linkFundingSources: Set<LinkSettings.FundingSource> | |||
| var linkFundingSources: [LinkSettings.FundingSource] | |||
There was a problem hiding this comment.
The idea behind using a set was to not care about the ordering in this test (and in general), but I guess the custom Equatable implementation doesn’t really allow for that 😔
There was a problem hiding this comment.
The issue is that we're serializing it to JSON data, and we sort the keys when doing that, but if we use a Set then the ordering is non-deterministic during the test.
87ed2ca
tillh-stripe
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This test has about a 50% chance of failing. To remedy this, I am proposing we continue to deserialize as a Set(), but during encoding, convert to an orderedlist.
Motivation
Deflaking test
Testing
Using existing tests
Changelog