-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read the default_payment_method field from elements session and use that as the default PM #4313
Merged
+260
−23
Merged
Changes from 41 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
1403094
reading default_payment_method from back end?
joyceqin-stripe 71c5516
revert accidental space changes;
joyceqin-stripe e3ecc2c
customersheet default from back end
joyceqin-stripe fb86faa
removed unused value
joyceqin-stripe b283446
Merge branch 'master' into joyceqin-MOBILESDK-2799
joyceqin-stripe 9ed5ed2
remove unused property
joyceqin-stripe e689449
Merge branch 'master' into joyceqin-MOBILESDK-2799
joyceqin-stripe 3c36c97
fix build issue
joyceqin-stripe c749e6e
Merge branch 'joyceqin-MOBILESDK-2799' of github.com:stripe/stripe-io…
joyceqin-stripe aac6ae1
fix test
joyceqin-stripe b25eb4b
merged with master
joyceqin-stripe 5936f96
Merge branch 'master' into joyceqin-MOBILESDK-2799
joyceqin-stripe 0fca0dc
check default pm against savedPaymentMethods instead of customer.paym…
joyceqin-stripe c226e09
removed alternateUpdatePaymentMethodNavigation, consolidated reading …
joyceqin-stripe 4d146b6
Merge branch 'master' into joyceqin-MOBILESDK-2799
joyceqin-stripe f858536
remove alternateUpdatePaymentMethodNavigation flag and updated tests
joyceqin-stripe 8d1c90b
update snapshot tests
joyceqin-stripe c70c6a1
update row button chevron condition
joyceqin-stripe d999b9e
remove removeonly mode, update tests
joyceqin-stripe ac5189a
fixing tests
joyceqin-stripe ffcf6e4
remove wait for chevron existence in tests for last card
joyceqin-stripe 403fdcb
localizable string
joyceqin-stripe c8fbfef
edit a test
joyceqin-stripe 2f515cd
merged with remove alternateupdatepaymentmethodnavigation flag
joyceqin-stripe 0a92c87
remove removeOnly snapshots
joyceqin-stripe a89890c
Merge branch 'master' into joyceqin-remove-alternateupdatepaymentmeth…
joyceqin-stripe bd51b31
changelog
joyceqin-stripe 3c69384
Merge branch 'master' into joyceqin-remove-alternateupdatepaymentmeth…
joyceqin-stripe f239d20
update changelog and tests
joyceqin-stripe 5fad2d3
Merge branch 'joyceqin-remove-alternateupdatepaymentmethodnavigation-…
joyceqin-stripe 4da3034
Merge branch 'master' into joyceqin-MOBILESDK-2799
joyceqin-stripe 05407cc
Merge branch 'joyceqin-remove-alternateupdatepaymentmethodnavigation-…
joyceqin-stripe eaae456
Merge branch 'master' into joyceqin-remove-alternateupdatepaymentmeth…
joyceqin-stripe 7022a11
sleep for 1 second to allow label animation to finish testRemovalOfSa…
joyceqin-stripe f5fbd58
Merge branch 'joyceqin-remove-alternateupdatepaymentmethodnavigation-…
joyceqin-stripe cb12138
Merge branch 'master' into joyceqin-MOBILESDK-2799
joyceqin-stripe 79f2a94
Revert space change
joyceqin-stripe b592b55
fallback when opted in to set as default not local default but first …
joyceqin-stripe 74c9db8
added tests
joyceqin-stripe dbc2beb
Merge branch 'joyceqin-MOBILESDK-2799' of github.com:stripe/stripe-io…
joyceqin-stripe 40574a6
Merge branch 'master' into joyceqin-MOBILESDK-2799
joyceqin-stripe 2e8b49e
no saved pms customersessionadapter test
joyceqin-stripe a2a37e6
removed explicit nil assignments when already implied
joyceqin-stripe 0b6781f
Merge branch 'joyceqin-MOBILESDK-2799' of github.com:stripe/stripe-io…
joyceqin-stripe 7d3f1c4
Merge branch 'master' into joyceqin-MOBILESDK-2799
joyceqin-stripe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to remove this, customerDefault is implied
nil
from it's definition. Same with other similar code paths in the PR.