Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UpdateCardViewController copy #3570

Merged
merged 5 commits into from
May 17, 2024
Merged

Update UpdateCardViewController copy #3570

merged 5 commits into from
May 17, 2024

Conversation

porter-stripe
Copy link
Collaborator

@porter-stripe porter-stripe commented May 7, 2024 •
edited
Loading

Summary

  • Updates the copy on the UpdateCardViewController to match the figma
  • Putting this up early to get into Lokalise. cc @yuki-stripe @amk-stripe

Motivation

CleanShot 2024-05-07 at 12 01 41

Testing

  • Snapshots updated

Changelog

N/A (but maybe?)

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024 •
edited
Loading

⚠️ Missing Translations

The following translations are missing in Lokalise. While they don't need to be downloaded into the codebase as part of this PR, they do need to exist in Lokalise so that they can be downloaded as part of the release process.

Update, Update card brand

By adding the label ship without translations to this PR, I acknowledge that there are missing translations.

@porter-stripe porter-stripe changed the title Update card view controller copy Update UpdateCardViewController copy May 7, 2024
@porter-stripe porter-stripe marked this pull request as ready for review May 17, 2024 15:47
@porter-stripe porter-stripe requested review from a team as code owners May 17, 2024 15:47
@porter-stripe porter-stripe requested a review from yuki-stripe May 17, 2024 15:47
@stripe stripe deleted a comment from github-actions bot May 17, 2024
yuki-stripe
yuki-stripe reviewed May 17, 2024
View reviewed changes
Copy link
Collaborator

@yuki-stripe yuki-stripe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We probably should wait until the translations are in before merging, since this is a live change.

What's the best way to do that? Remove the ship without translations label and run the 'download localizations' script in this branch before merging?

@porter-stripe
Copy link
Collaborator Author

porter-stripe commented May 17, 2024 •
edited
Loading

@yuki-stripe translations are in, the "Check Missing Translations" check is passing w/o the "ships w/o translations" label. They'll be downloaded in the next release in the proposal PR.

https://trailhead.corp.stripe.com/docs/mobile-sdk/shared-infrastructure/mobile-sdk-localizations#localization-flow

@porter-stripe porter-stripe enabled auto-merge (squash) May 17, 2024 17:26
@porter-stripe porter-stripe requested a review from yuki-stripe May 17, 2024 17:29
@porter-stripe porter-stripe merged commit b2e9ac9 into master May 17, 2024
5 checks passed
@porter-stripe porter-stripe deleted the porter/MOBILESDK-2030 branch May 17, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuki-stripe yuki-stripe yuki-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@porter-stripe @yuki-stripe