Add VerticalSavedPaymentOptionsViewController #3569
Conversation
StripePaymentSheet/StripePaymentSheet/Resources/Localizations/en.lproj/Localizable.strings
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheet/Source/Categories/String+Localized.swift
Outdated
Show resolved
Hide resolved
...ipePaymentSheet/Source/PaymentSheet/ViewControllers/PaymentSheetVerticalViewController.swift
Show resolved
Hide resolved
...rce/PaymentSheet/Saved Payment Method Screen/VerticalSavedPaymentOptionsViewController.swift
Show resolved
Hide resolved
...rce/PaymentSheet/Saved Payment Method Screen/VerticalSavedPaymentOptionsViewController.swift
Show resolved
Hide resolved
| testWindow.overrideUserInterfaceStyle = .dark | ||
| } | ||
| testWindow.rootViewController = sut | ||
| sut.view.autosizeHeight(width: 375, height: 280) |
There was a problem hiding this comment.
I think you shouldn't pass a height here. That way it gets sized to the content's height.
There was a problem hiding this comment.
Makes sense, fixed!
| @@ -234,4 +234,11 @@ extension String.Localized { | |||
| "Amazon Pay mandate text" | |||
| ) | |||
| } | |||
|
|
|||
| static var select_your_payment_method: String { | |||
There was a problem hiding this comment.
FYI we won't use this string. The whimsical doesn't contain the latest copy - see the Figma instead.
|
The following translations are missing in Lokalise. While they don't need to be downloaded into the codebase as part of this PR, they do need to exist in Lokalise so that they can be downloaded as part of the release process. Select card, Select payment method By adding the label |
|
Added the ship w/o translations label since these are net new stings only being used in an unreleased feature. I anticipate they will be translated by the time we release. |
| headerLabel.text = .Localized.select_your_payment_method | ||
| headerLabel.text = STPLocalizedString( | ||
| "Select your payment method", | ||
| "Title shown above a carousel containing the customer's payment methods") |
There was a problem hiding this comment.
Wait this felt like a good change, can we keep it?
Summary
Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-05-07.at.10.22.01.mp4
Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-2023
Testing
Changelog
N/A