Replace exec package with execabs #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etsai-stripe
approved these changes
Feb 16, 2022
|
is throwing the error more explicitly the intention here? |
Yeah. The executables we want to run are in a Windows system folder, and we have no reason to run executables outside of that. If that ever happens, then we should throw an error, which this package does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @stripe/developer-products
cc @stripe/developer-products
Summary
This replacement package always looks for the executable in an absolute path, and throws an error if the executable is in a relative path. Note that this only affects the behavior of certain commands on Windows; other operating systems are unaffected.
Internally, see here for more info.