Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require credit postal for only US, CA, and GB #4165

Merged
merged 2 commits into from
Sep 7, 2021

Conversation

michelleb-stripe
Copy link
Contributor

@michelleb-stripe michelleb-stripe commented Sep 2, 2021

Summary

Change the credit card postal code so it is only required for: US, CA, and GB to match other Stripe UIs.

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-341

Testing

  • Added tests
  • Modified tests
  • Manually verified

@michelleb-stripe michelleb-stripe self-assigned this Sep 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │  11.5 MiB │  11.5 MiB │ -961 B │  39.3 MiB │  39.3 MiB │ -288 B 
     arsc │   1.3 MiB │   1.3 MiB │    0 B │   1.3 MiB │   1.3 MiB │    0 B 
 manifest │   2.5 KiB │   2.5 KiB │    0 B │  10.5 KiB │  10.5 KiB │    0 B 
      res │ 639.4 KiB │ 639.4 KiB │    0 B │ 997.8 KiB │ 997.8 KiB │    0 B 
    asset │  77.7 KiB │  77.7 KiB │   +1 B │ 109.1 KiB │ 109.1 KiB │   +1 B 
    other │    78 KiB │    78 KiB │    0 B │   154 KiB │   154 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  13.6 MiB │  13.6 MiB │ -960 B │  41.8 MiB │  41.8 MiB │ -287 B 


         │          raw           │            unique            
         ├────────┬────────┬──────┼────────┬────────┬────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff       
─────────┼────────┼────────┼──────┼────────┼────────┼────────────
   files │      3 │      3 │    0 │        │        │            
 strings │ 178789 │ 178786 │   -3 │ 165692 │ 165690 │ -2 (+4 -6) 
   types │  31479 │  31479 │    0 │  29842 │  29842 │  0 (+0 -0) 
 classes │  27552 │  27552 │    0 │  27552 │  27552 │  0 (+0 -0) 
 methods │ 158946 │ 158946 │    0 │ 154639 │ 154639 │  0 (+1 -1) 
  fields │ 108310 │ 108310 │    0 │ 107960 │ 107960 │  0 (+1 -1) 


 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  293 │  293 │  0   
 entries │ 4324 │ 4324 │  0
APK
    compressed    │   uncompressed    │                               
─────────┬────────┼──────────┬────────┤                               
 size    │ diff   │ size     │ diff   │ path                          
─────────┼────────┼──────────┼────────┼───────────────────────────────
 3.5 MiB │ -961 B │ 10.1 MiB │ -288 B │ ∆ classes2.dex                
 5.4 KiB │   +1 B │  5.3 KiB │   +1 B │ ∆ assets/dexopt/baseline.prof 
─────────┼────────┼──────────┼────────┼───────────────────────────────
 3.5 MiB │ -960 B │ 10.1 MiB │ -287 B │ (total)
DEX
STRINGS:

   old    │ new    │ diff       
  ────────┼────────┼────────────
   165692 │ 165690 │ -2 (+4 -6) 
  
  + CARD_POSTAL_CODE_COUNTRIES
  + SMAP
  Comparisons.kt
  Kotlin
  *S Kotlin
  *F
  + 1 Comparisons.kt
  kotlin/comparisons/ComparisonsKt__ComparisonsKt_compareBy_2
  + 2 CountryUtils.kt
  com/stripe/android/view/CountryUtils
  *L
  1#1,320:1
  47#2:321
  *E
  
  + SMAP
  CountryUtils.kt
  Kotlin
  *S Kotlin
  *F
  + 1 CountryUtils.kt
  com/stripe/android/view/CountryUtils
  + 2 _Arrays.kt
  kotlin/collections/ArraysKt___ArraysKt
  + 3 _Collections.kt
  kotlin/collections/CollectionsKt___CollectionsKt
  *L
  1#1,69:1
  11328#2:70
  11663#2,3:71
  286#3,2:74
  286#3,2:76
  1043#3:78
  817#3:79
  845#3,2:80
  *S KotlinDebug
  *F
  + 1 CountryUtils.kt
  com/stripe/android/view/CountryUtils
  *L
  15#1:70
  15#1:71,3
  30#1:74,2
  35#1:76,2
  47#1:78
  48#1:79
  48#1:80,2
  *E
  
  + getCARD_POSTAL_CODE_COUNTRIES_payments_core_release
  
  - AN
  - NO_POSTAL_CODE_COUNTRIES
  - SMAP
  Comparisons.kt
  Kotlin
  *S Kotlin
  *F
  + 1 Comparisons.kt
  kotlin/comparisons/ComparisonsKt__ComparisonsKt_compareBy_2
  + 2 CountryUtils.kt
  com/stripe/android/view/CountryUtils
  *L
  1#1,320:1
  52#2:321
  *E
  
  - SMAP
  CountryUtils.kt
  Kotlin
  *S Kotlin
  *F
  + 1 CountryUtils.kt
  com/stripe/android/view/CountryUtils
  + 2 _Arrays.kt
  kotlin/collections/ArraysKt___ArraysKt
  + 3 _Collections.kt
  kotlin/collections/CollectionsKt___CollectionsKt
  *L
  1#1,74:1
  11328#2:75
  11663#2,3:76
  286#3,2:79
  286#3,2:81
  1043#3:83
  817#3:84
  845#3,2:85
  *S KotlinDebug
  *F
  + 1 CountryUtils.kt
  com/stripe/android/view/CountryUtils
  *L
  20#1:75
  20#1:76,3
  35#1:79,2
  40#1:81,2
  52#1:83
  53#1:84
  53#1:85,2
  *E
  
  - SY
  - getNO_POSTAL_CODE_COUNTRIES_payments_core_release
  

METHODS:

   old    │ new    │ diff      
  ────────┼────────┼───────────
   154639 │ 154639 │ 0 (+1 -1) 
  
  + com.stripe.android.view.CountryUtils getCARD_POSTAL_CODE_COUNTRIES_payments_core_release() → Set
  
  - com.stripe.android.view.CountryUtils getNO_POSTAL_CODE_COUNTRIES_payments_core_release() → Set
  

FIELDS:

   old    │ new    │ diff      
  ────────┼────────┼───────────
   107960 │ 107960 │ 0 (+1 -1) 
  
  + com.stripe.android.view.CountryUtils CARD_POSTAL_CODE_COUNTRIES: Set
  
  - com.stripe.android.view.CountryUtils NO_POSTAL_CODE_COUNTRIES: Set

@michelleb-stripe michelleb-stripe changed the title [WIP] Require credit postal for only US, CA, and GB Require credit postal for only US, CA, and GB Sep 7, 2021
@michelleb-stripe michelleb-stripe merged commit ba8a479 into master Sep 7, 2021
@michelleb-stripe michelleb-stripe deleted the michelle/require-postal branch September 7, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants