use suspend fun in example app #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be443bd to
b9d869e
Compare
|
removed checkbox per feedback from iOS team |
mshafrir-stripe
requested changes
Apr 21, 2021
example/src/main/java/com/stripe/example/activity/CreateCardTokenActivity.kt
Outdated
Show resolved
Hide resolved
b7ba48f to
e02c481
Compare
mshafrir-stripe
requested changes
Apr 21, 2021
| override fun onError(e: Exception) { | ||
| viewModel.paymentIntentResultLiveData.value = Result.failure(e) | ||
| } | ||
| if (stripe.isPaymentResult(requestCode, data)) { |
There was a problem hiding this comment.
can you add a null check for data so we don't need to use !!?
There was a problem hiding this comment.
stripe.isPaymentResult already checks nullability within, I think it's worth bring to the client's attention it does that. Added a comment here, wdty?
There was a problem hiding this comment.
This is fine, just thinking that there might be some future scenario where isPaymentResult stops checking for data's nullity and this crashes. Or maybe getPaymentIntentResult should just take a Intent??
|
|
||
| override fun onError(e: Exception) { | ||
| viewModel.paymentIntentResultLiveData.value = Result.failure(e) | ||
| if (stripe.isPaymentResult(requestCode, data)) { |
There was a problem hiding this comment.
can you add a null check for data so we don't need to use !!?
mshafrir-stripe
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a check box to toggle using regular API and suspend API
Motivation
Demonstrate suspend APIs added in #3557 and #3568
Testing