Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PaymentSession.handlePaymentData() to take a nullable Intent #2988

Merged
merged 4 commits into from
Oct 29, 2020

Conversation

mshafrir-stripe
Copy link
Collaborator

@mshafrir-stripe mshafrir-stripe commented Oct 29, 2020

handlePaymentData() is typically called from onActivityResult().
onActivityResult() can receive a null Intent instance, so make
handlePaymentData() match this.

Fixes #2987

`handlePaymentData()` is typically called from `onActivityResult()`.
`onActivityResult()` can receive ` null `Intent` instance, so make
`handlePaymentData()` match this.

Fixes #2987
pardo-stripe
pardo-stripe previously approved these changes Oct 29, 2020
Copy link

@pardo-stripe pardo-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@pardo-stripe pardo-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@mshafrir-stripe mshafrir-stripe merged commit d8c3a67 into master Oct 29, 2020
@mshafrir-stripe mshafrir-stripe deleted the ps-handle-payment-data branch October 29, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PaymentSession handlePaymentData Parameter specified as non-null is null:
4 participants