Fix vector icon references in layout files #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `vectorDrawables.useSupportLibrary = true` to `build.gradle` [0]. Without this, when targeting API <= 19, PNG versions of vector drawables will be generated at build time. This reduces the SDK's filesize from 219kb to 189kb. Use `app:srcCompat` instead of `android:src` when referencing vector drawables. Fix some drawable dimensions and layouts. Fixes #2578 [0] https://developer.android.com/guide/topics/graphics/vector-drawable-resources#vector-drawables-backward-solution
chander-stripe
approved these changes
Jun 15, 2020
|
I just had to do this for the standalone app too haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
vectorDrawables.useSupportLibrary = truetobuild.gradle[0].Without this, when targeting API <= 19, PNG versions of vector
drawables will be generated at build time. This reduces the SDK's
filesize from 219kb to 189kb.
Use
app:srcCompatinstead ofandroid:srcwhen referencing vectordrawables.
Fix some drawable dimensions and layouts.
[0] https://developer.android.com/guide/topics/graphics/vector-drawable-resources#vector-drawables-backward-solution
Motivation
Fixes #2578
Testing
Manually tested