Add CardValidCallback and add support in card forms #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary Add `CardInputWidget#setCardValidCallback()` and `CardMultilineWidget#setCardValidCallback()` Setting a callback instance will allow the integrating app to determine if the current form input is valid and which fields are invalid, if any. For example, when none of the fields are valid, `CardValidCallback#onInputChanged()` will be called with ``` false, setOf( CardValidCallback.Fields.Number, CardValidCallback.Fields.Expiry, CardValidCallback.Fields.Cvc ) ``` When all of the fields are valid, `CardValidCallback#onInputChanged()` will be called with ``` true, emptySet() ``` Testing Add unit tests and manually verified Motivation Fixes #1808
markfi-stripe
approved these changes
Jan 23, 2020
3ed36fe to
181423b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
CardInputWidget#setCardValidCallback()andCardMultilineWidget#setCardValidCallback()Setting a callback instance will allow the integrating
app to determine if the current form input is valid
and which fields are invalid, if any.
For example, when none of the fields are valid,
CardValidCallback#onInputChanged()will be called withWhen all of the fields are valid,
CardValidCallback#onInputChanged()will be called withTesting
Add unit tests and manually verified
Motivation
Fixes #1808