Fix CardNumberEditText performance #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CardNumberEditText`'s `TextWatcher` was modifying the underlying text field in `onTextChanged()`, which was causing performance issues. Changes to the text field should be done in `afterTextChanged()`. Update `CardNumberEditTextTest` tests to use `setText()` instead of `append()`, because `setText()` better simulates a user typing into a field. Fixes #1145
felipecsl-stripe
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CardNumberEditText'sTextWatcherwas modifying theunderlying text field in
onTextChanged(), which wascausing performance issues. Changes to the text field
should be done in
afterTextChanged().Update
CardNumberEditTextTesttests to usesetText()instead of
append(), becausesetText()bettersimulates a user typing into a field.
Fixes #1145