Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Received unknown parameter: account[legal_entity] #821

Closed
rafikmechria opened this issue Mar 3, 2019 · 8 comments
Closed

Received unknown parameter: account[legal_entity] #821

rafikmechria opened this issue Mar 3, 2019 · 8 comments
Assignees
@mshafrir-stripe

Comments

@rafikmechria
Copy link

Summary

I am using the new api version of stripe :2019-02-19 last version on the platform.
there is a bug or missing development stuff in stripe-android integration when calling this method :
Token token= stripe.createAccountTokenSynchronous(AccountParams.createAccountParams(true,LegalEntityMap)) 
The method keep returning :
Received unknown parameter: account[legal_entity] 

Since you removed the legal_entity parameter from your new api and updated with individual parameter , normally you should update that too in the stripe android SDK integration.
Please respond, thanks.

Code to reproduce

Android version

Impacted devices

Installation method

SDK version

Other information
@mshafrir-stripe mshafrir-stripe self-assigned this Mar 4, 2019
@mshafrir-stripe
Copy link
Collaborator

@rafikmechria thanks for filing. I'm able to reproduce the issue and will put up a fix shortly.

mshafrir-stripe added a commit that referenced this issue Mar 4, 2019
@mshafrir-stripe
Fix account token failure on latest API version
2620a9f 
**Summary**
- Create `ApiVersion` class to represent a Stripe API version
- Overload `Stripe#createAccountTokenSynchronous` methods that
  accept `ApiVersion` argument
- Update `AccountParams` to support `individual` and `company`
  business types
- Add tests for `2019-02-19` API changes to the Account API

**Motivation**
Fixes #821
@mshafrir-stripe mshafrir-stripe mentioned this issue Mar 4, 2019
Merged
@mshafrir-stripe
Copy link
Collaborator

@rafikmechria I put up a fix (#822). Feel free to test it and see if it resolves your issue.

mshafrir-stripe added a commit that referenced this issue Mar 4, 2019
@mshafrir-stripe
Fix account token failure on latest API version
95a91cc 
**Summary**
- Create `ApiVersion` class to represent a Stripe API version
- Overload `Stripe#createAccountTokenSynchronous` methods that
  accept `ApiVersion` argument
- Update `AccountParams` to support `individual` and `company`
  business types
- Add tests for `2019-02-19` API changes to the Account API

**Motivation**
Fixes #821
@mshafrir-stripe
Copy link
Collaborator

@rafikmechria in the mean time, are you still able to roll back to a previous version? You have 72 hours to roll back.

@rafikmechria
Copy link
Author

Why you don't just release a new sdk update ?

@mshafrir-stripe
Copy link
Collaborator

@rafikmechria I can do that once the PR merges and we go through our release procedures. It was a suggestion in case this is a blocking issue and roll back is still a viable option.

@rafikmechria
Copy link
Author

My stripe account is new and points me directly to the new version, How do they remove legal entity parameters in the api without preparing an update for the sdks(Android,ios js)??

mshafrir-stripe added a commit that referenced this issue Mar 4, 2019
@mshafrir-stripe
Fix account token failure on latest API version
a520aee 
**Summary**
- Create `ApiVersion` class to represent a Stripe API version
- Overload `Stripe#createAccountTokenSynchronous` methods that
  accept `ApiVersion` argument
- Update `AccountParams` to support `individual` and `company`
  business types
- Add tests for `2019-02-19` API changes to the Account API

**Motivation**
Fixes #821
mshafrir-stripe added a commit that referenced this issue Mar 4, 2019
@mshafrir-stripe
Fix account token failure on latest API version (#822)
e7ff53c 
**Summary**
- Create `ApiVersion` class to represent a Stripe API version
- Overload `Stripe#createAccountTokenSynchronous` methods that
  accept `ApiVersion` argument
- Update `AccountParams` to support `individual` and `company`
  business types
- Add tests for `2019-02-19` API changes to the Account API

**Motivation**
Fixes #821
@mshafrir-stripe
Copy link
Collaborator

@rafikmechria I just released stripe-android:8.5.0 with support for the Account API changes. It should take some propagate so it may be several hours before it's available to you. The latest version is also pinned to API version 2017-06-05, but the changes to the params will work on that version as well.

@rafikmechria
Copy link
Author

alright , thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mshafrir-stripe mshafrir-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafikmechria @mshafrir-stripe