Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved ignored annotations in PvcOperator #8674

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Jun 15, 2023

Type of change

  • Bugfix

Description

The PvcOperator class already ignores some Kubernetes annotations. But as discussed in #8667, there are some more that we should ignore as well and not patch them. This PR expands the range of ignored annotations.

Checklist

  • Write tests
  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.36.0 milestone Jun 15, 2023
@scholzj scholzj requested a review from ppatierno June 15, 2023 10:14
@scholzj
Copy link
Member Author

scholzj commented Jun 15, 2023

/azp run regression

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's another use case relevant for strimzi/proposals#80.

@scholzj scholzj changed the title Improved ignored annotations in PvcOperator - Closes #8667 Improved ignored annotations in PvcOperator Jun 15, 2023
@scholzj scholzj merged commit 15a9d66 into strimzi:main Jun 15, 2023
@scholzj scholzj deleted the improve-ignored-fields-in-PvcOperator branch June 15, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants