Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stub CertManager in unit tests #535

Closed
tombentley opened this issue Jul 3, 2018 · 0 comments · Fixed by #536
Closed

Stub CertManager in unit tests #535

tombentley opened this issue Jul 3, 2018 · 0 comments · Fixed by #536

Comments

@tombentley
Copy link
Member

The unit tests run much more slowing following the merge of #487 the CO unit tests run much more slowly because they create a lot of clusters, and we generate certs for each one. To keep the unit tests fast we should use a different impl of CertManager for the unit tests which aren't testing TLS-related functionality.
tombentley added a commit that referenced this issue Jul 3, 2018
@tombentley
Use a MockCertManager in the tests, pass the same instances to places…
80945bb 
… that need a CertManager via parameters

Fixes #535
@tombentley tombentley mentioned this issue Jul 3, 2018
Merged
6 tasks
tombentley added a commit that referenced this issue Jul 4, 2018
@tombentley
Use a MockCertManager in the tests (#536)
61d2717 
Pass a single instance to places that need a CertManager via parameters 

Fixes #535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tombentley