feat!: Require Node 18+ (#4955)

streetsidesoftware · Nov 7, 2023 · a5988b9 · a5988b9
1 parent 77c7fb3
commit a5988b9
Show file tree

Hide file tree

Showing 61 changed files with 71 additions and 97 deletions.
diff --git a/.github/workflows/build-version-release.yml b/.github/workflows/build-version-release.yml
@@ -72,7 +72,7 @@ jobs:
       - name: Use Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 18
           registry-url: "https://registry.npmjs.org"
           cache: pnpm
 

diff --git a/.github/workflows/deploy-website.yml b/.github/workflows/deploy-website.yml
@@ -25,7 +25,7 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 16.x
+          node-version: 18.x
           cache: pnpm
 
       - name: Build website

diff --git a/.github/workflows/integration-test.yml b/.github/workflows/integration-test.yml
@@ -34,8 +34,8 @@ permissions:
 
 env:
   RUNS_ON: ubuntu-latest
-  NODE_VERSION: "16.x"
-  NPM_VERSION: "8"
+  NODE_VERSION: "18.x"
+  NPM_VERSION: "9"
 
 jobs:
   pre-build:

diff --git a/.github/workflows/reuseable-build-dist-cache.yml b/.github/workflows/reuseable-build-dist-cache.yml
@@ -44,8 +44,8 @@ permissions:
   contents: read
 
 env:
-  NODE_VERSION: "16.x"
-  NPM_VERSION: "8"
+  NODE_VERSION: "18.x"
+  NPM_VERSION: "9"
 
 jobs:
   build:

diff --git a/.github/workflows/reuseable-load-integrations-repo-list.yml b/.github/workflows/reuseable-load-integrations-repo-list.yml
@@ -28,8 +28,8 @@ permissions:
 
 env:
   RUNS_ON: ubuntu-latest
-  NODE_VERSION: "16.x"
-  NPM_VERSION: "8"
+  NODE_VERSION: "18.x"
+  NPM_VERSION: "9"
 
 jobs:
   load:

diff --git a/.github/workflows/smoke-test.yml b/.github/workflows/smoke-test.yml
@@ -63,9 +63,9 @@ jobs:
       fail-fast: false
       matrix:
         node-version:
-          - 16.x
           - 18.x
           - 20.x
+          - 21.x
 
         os:
           - ubuntu-latest

diff --git a/.github/workflows/test-build-docs.yml b/.github/workflows/test-build-docs.yml
@@ -16,7 +16,7 @@ jobs:
       matrix:
         node-version:
           # List of supported node versions (latest is tested in `test-os`)
-          - 16.x
+          - 18.x
 
         os:
           - ubuntu-latest

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -43,9 +43,9 @@ jobs:
       matrix:
         node-version:
           # List of supported node versions (latest is tested in `test-os`)
-          - 16.x
           - 18.x
           - 20.x
+          - 21.x
 
         os:
           - ubuntu-latest
@@ -123,8 +123,8 @@ jobs:
       matrix:
         node-version:
           # List of supported node versions (latest is tested in `test-os`)
-          - 16.x
           - 20.x
+          - 21.x
 
         os:
           - ubuntu-latest
@@ -160,29 +160,3 @@ jobs:
 
       # Ensure the repository is clean after build & test
       - run: git --no-pager diff --exit-code
-
-  test-node-19:
-    runs-on: ${{ matrix.os }}
-
-    strategy:
-      matrix:
-        node-version:
-          # List of supported node versions (latest is tested in `test-os`)
-          - 20.x
-
-        os:
-          - ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Setup
-        uses: ./.github/actions/install-build
-        with:
-          node-version: ${{ matrix.node-version }}
-
-      - run: pnpm -r --filter ./packages/cspell run test
-
-      # Node 19 has started to fail if concurrency is not set to 1
-      # both jest and pnpm run in parallel overloading the machine.
-      - run: pnpm --workspace-concurrency 1 test
diff --git a/.github/workflows/update-integration-repositories.yml b/.github/workflows/update-integration-repositories.yml
@@ -16,8 +16,8 @@ env:
   NEW_BRANCH: "update-integration-repositories"
   REF_BRANCH_G: main
   RUNS_ON: ubuntu-latest
-  NODE_VERSION: "16.x"
-  NPM_VERSION: "8"
+  NODE_VERSION: "18.x"
+  NPM_VERSION: "9"
 
 jobs:
   calc-ref:

diff --git a/doc-generator/package.json b/doc-generator/package.json
@@ -11,7 +11,7 @@
   "author": "",
   "license": "MIT",
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "dependencies": {
     "typedoc": "^0.25.3",

diff --git a/integration-tests/package.json b/integration-tests/package.json
@@ -8,7 +8,7 @@
     "normalize-output": "scripts/normalize-output.mjs"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "scripts": {
     "build": "tsc -p .",

diff --git a/package.json b/package.json
@@ -8,7 +8,7 @@
     "cspell": "bin.mjs",
     "cspell-tools": "cspell-tools.mjs"
   },
-  "packageManager": "pnpm@8.7.4",
+  "packageManager": "pnpm@8.10.2",
   "private": true,
   "scripts": {
     "bt": "pnpm run build && pnpm run test",
@@ -97,7 +97,7 @@
     "@rollup/plugin-node-resolve": "^15.2.3",
     "@rollup/plugin-terser": "^0.4.4",
     "@rollup/plugin-typescript": "^11.1.5",
-    "@tsconfig/node16": "^16.1.1",
+    "@tsconfig/node18": "^18.2.2",
     "@types/node": "^18.18.8",
     "@typescript-eslint/eslint-plugin": "^5.62.0",
     "@typescript-eslint/parser": "^5.62.0",

diff --git a/packages/cspell-bundled-dicts/package.json b/packages/cspell-bundled-dicts/package.json
@@ -94,7 +94,7 @@
     "@cspell/dict-vue": "^3.0.0"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "devDependencies": {
     "@cspell/cspell-tools": "workspace:*",

diff --git a/packages/cspell-code-snippets/package.json b/packages/cspell-code-snippets/package.json
@@ -27,7 +27,7 @@
   },
   "homepage": "https://github.com/streetsidesoftware/cspell#readme",
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "devDependencies": {
     "@types/jest": "^29.5.7",

diff --git a/packages/cspell-config-lib/package.json b/packages/cspell-config-lib/package.json
@@ -39,7 +39,7 @@
     "url": "https://github.com/streetsidesoftware/cspell/labels/cspell-config"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "dependencies": {
     "@cspell/cspell-types": "workspace:*",

diff --git a/packages/cspell-dictionary/package.json b/packages/cspell-dictionary/package.json
@@ -42,7 +42,7 @@
   },
   "homepage": "https://github.com/streetsidesoftware/cspell#readme",
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "dependencies": {
     "@cspell/cspell-pipe": "workspace:*",

diff --git a/packages/cspell-eslint-plugin/package.json b/packages/cspell-eslint-plugin/package.json
@@ -56,7 +56,7 @@
     "url": "https://github.com/streetsidesoftware/cspell/labels/cspell-gitignore"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "devDependencies": {
     "@types/eslint": "^8.44.7",

diff --git a/packages/cspell-gitignore/package.json b/packages/cspell-gitignore/package.json
@@ -48,7 +48,7 @@
     "url": "https://github.com/streetsidesoftware/cspell/labels/cspell-gitignore"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "dependencies": {
     "cspell-glob": "workspace:*",

diff --git a/packages/cspell-glob/package.json b/packages/cspell-glob/package.json
@@ -45,7 +45,7 @@
     "url": "https://github.com/streetsidesoftware/cspell/labels/cspell-glob"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "dependencies": {
     "micromatch": "^4.0.5"

diff --git a/packages/cspell-grammar/package.json b/packages/cspell-grammar/package.json
@@ -76,7 +76,7 @@
     "url": "https://github.com/streetsidesoftware/cspell/labels/cspell-grammar"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "devDependencies": {
     "jest": "^29.7.0"

diff --git a/packages/cspell-io/package.json b/packages/cspell-io/package.json
@@ -43,7 +43,7 @@
   },
   "homepage": "https://github.com/streetsidesoftware/cspell#readme",
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "devDependencies": {
     "@types/node-fetch": "^2.6.8",

diff --git a/packages/cspell-json-reporter/package.json b/packages/cspell-json-reporter/package.json
@@ -46,6 +46,6 @@
     "@cspell/cspell-types": "workspace:*"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   }
 }
diff --git a/packages/cspell-lib/package.json b/packages/cspell-lib/package.json
@@ -80,7 +80,7 @@
     "vscode-uri": "^3.0.8"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "devDependencies": {
     "@cspell/dict-cpp": "^5.0.9",

diff --git a/packages/cspell-pipe/package.json b/packages/cspell-pipe/package.json
@@ -110,7 +110,7 @@
     "url": "https://github.com/streetsidesoftware/cspell/labels/cspell-pipe"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "devDependencies": {
     "globby": "^13.2.2"

diff --git a/packages/cspell-resolver/package.json b/packages/cspell-resolver/package.json
@@ -44,7 +44,7 @@
     "url": "https://github.com/streetsidesoftware/cspell/issues"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "dependencies": {
     "global-dirs": "^3.0.1"

diff --git a/packages/cspell-service-bus/package.json b/packages/cspell-service-bus/package.json
@@ -48,6 +48,6 @@
     "url": "https://github.com/streetsidesoftware/cspell/labels/cspell-service-bus"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   }
 }
diff --git a/packages/cspell-strong-weak-map/package.json b/packages/cspell-strong-weak-map/package.json
@@ -51,6 +51,6 @@
     "url": "https://github.com/streetsidesoftware/cspell"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   }
 }
diff --git a/packages/cspell-tools/package.json b/packages/cspell-tools/package.json
@@ -58,7 +58,7 @@
     "yaml": "^2.3.4"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "devDependencies": {
     "@types/glob": "^8.1.0",

diff --git a/packages/cspell-trie-lib/package.json b/packages/cspell-trie-lib/package.json
@@ -51,7 +51,7 @@
     "gensequence": "^6.0.0"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "devDependencies": {
     "@cspell/dict-en_us": "^4.3.11",

diff --git a/packages/cspell-trie/package.json b/packages/cspell-trie/package.json
@@ -44,6 +44,6 @@
     "gensequence": "^6.0.0"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   }
 }
diff --git a/packages/cspell-types/package.json b/packages/cspell-types/package.json
@@ -82,6 +82,6 @@
   "author": "Jason Dent",
   "license": "MIT",
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   }
 }
diff --git a/packages/cspell/package.json b/packages/cspell/package.json
@@ -100,7 +100,7 @@
     "vscode-uri": "^3.0.8"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "devDependencies": {
     "@types/file-entry-cache": "^5.0.4",

diff --git a/packages/dynamic-import/package.json b/packages/dynamic-import/package.json
@@ -53,7 +53,7 @@
     "url": "https://github.com/streetsidesoftware/cspell/labels/cspell-pipe"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18.0"
   },
   "dependencies": {
     "import-meta-resolve": "^3.1.1"

diff --git a/packages/hunspell-reader/package.json b/packages/hunspell-reader/package.json
@@ -49,6 +49,6 @@
     "iconv-lite": "^0.6.3"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   }
 }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/scripts/package.json b/scripts/package.json
@@ -15,7 +15,7 @@
   "author": "",
   "license": "MIT",
   "engines": {
-    "node": ">16.0"
+    "node": ">=18.0"
   },
   "devDependencies": {
     "esbuild": "0.19.4"
-Original file line number
+Diff line change
@@ Expand Up / @@ -63,9 +63,9 @@ jobs: @@
           fail-fast: false
           matrix:
             node-version:
-              - 16.x
               - 18.x
               - 20.x
+              - 21.x
             os:
               - ubuntu-latest
@@ Expand Down @@