feat(cli-tool): add binary support to publish #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harbu
commented
Dec 13, 2024
| } | ||
| const partitionKey = (partitionKeyField !== undefined) ? json[partitionKeyField] : undefined | ||
| client.publish(stream, json, { partitionKey }).then( | ||
| const partitionKey = (partitionKeyField !== undefined && typeof message === 'object') ? message[partitionKeyField] : undefined |
There was a problem hiding this comment.
Notice: partitionKeyField only makes sense on JSON objects.
teogeb
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Subcommand
streamr stream publishnow supports binary publishing. If the input is detected to be a hexadecimal string, it will be interpreted as binary and pushed to the network as such.Checklist before requesting a review
TODOcomments left behind are meant to be left in.