-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk)!: Do not set metadata defaults in Stream
constructor
#2851
Merged
teogeb
merged 19 commits into
main
from
do-not-set-defaults-for-metadata-in-Stream-constructor
Nov 5, 2024
Merged
feat(sdk)!: Do not set metadata defaults in Stream
constructor
#2851
teogeb
merged 19 commits into
main
from
do-not-set-defaults-for-metadata-in-Stream-constructor
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etadata-in-Stream-constructor
juslesan
approved these changes
Nov 4, 2024
teogeb
deleted the
do-not-set-defaults-for-metadata-in-Stream-constructor
branch
November 5, 2024 13:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change as the value returned by
getMetadata()
is different.The
Stream
constructor no longer sets default values for anymetadata
fields. Before this PR the constructor initialized values forpartitions
andfields
values. As metadata is now untyped (#2845), it makes sense to drop these defaults.Also the internal
Streamr#parseMetadata()
no longer sets default value for thepartitions
field .Implications
Stream#getMetadata()
now returns metadata exactly as it stored in the stream registry.Stream#getPartitionCount()
method. It defaults to theDEFAULT_PARTITION_COUNT
if there is no value available in metadata.Stream#getMetadata().partitions
.