feat(network): Improve StreamPartitionInfo compatibility
#2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d46ddef to
79f594c
Compare
juslesan
approved these changes
Oct 7, 2024
teogeb
added a commit
to streamr-dev/stream-metrics-index
that referenced
this pull request
Oct 28, 2024
## Changes - The `NodeInfo` format has changed (streamr-dev/network#2738, streamr-dev/network#2790) - we normalize the info in `NetworkNodeFacade` - the type of `NormalizedNodeInfo` is quite complex, but it will be simpler when we export new helper types from `trackerless-network` (streamr-dev/network#2822, not yet released) - Using renamed converted functions, e.g. `getNodeIdFromPeerDescriptor` to `toNodeId` ## Future improvements - Use these types: streamr-dev/network#2822
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve backwards compatibility for
StreamPartitionInfo. The format forcontentDeliveryLayerNeighborsfield was changed in #2738.Open questions
deprecatedContentDeliveryLayerNeighborsfield to achieve better compatibility? With the current approach caller checks the version number and decides which field to read.