fix(network): exclude initial ws neighbors for parallel operations #2727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As we run parallel handshaking algorithms now it makes sense to push the WS node to the excluded list immediately. This way the same WS server cannot be picked
Future improvements
Explore more general exclusion in general. Parallel handshaking operations can be done to the same nodes. Naively pushing attempted handshakes to the exclude list breaks some tests.