Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network): exclude initial ws neighbors for parallel operations #2727

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

juslesan
Copy link
Contributor

Summary

As we run parallel handshaking algorithms now it makes sense to push the WS node to the excluded list immediately. This way the same WS server cannot be picked

Future improvements

Explore more general exclusion in general. Parallel handshaking operations can be done to the same nodes. Naively pushing attempted handshakes to the exclude list breaks some tests.

@juslesan juslesan requested a review from harbu August 23, 2024 09:38
@github-actions github-actions bot added the network Related to Network Package label Aug 23, 2024
@juslesan
Copy link
Contributor Author

900 runs:

-------------------------------
Time to start network stack
mean: 372.1355555555556
median: 292.5
max: 3434
min: 147
std: 461.71627586914144
-------------------------------
Time to fetch stream entry points
mean: 103.43487858719647
median: 80
max: 5140
min: 9
std: 215.12270398084817
-------------------------------
Time to first neighbor
mean: 794.460511679644
median: 429
max: 17402
min: 216
std: 1311.6120511801776
-------------------------------
Time to first message in network
mean: 854.8622222222223
median: 499.5
max: 17422
min: 221
std: 1317.7143464328915
-------------------------------
Time to validate
mean: 977.94
median: 566
max: 13609
min: 437
std: 1415.094531887456
-------------------------------
Time to first message
mean: 2493.6566666666668
median: 1771.5
max: 18558
min: 1142
std: 1945.860233335832

@harbu harbu merged commit 0a0e13e into main Aug 26, 2024
24 checks passed
@harbu harbu deleted the exclude-initial-ws-neighbors branch August 26, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network Related to Network Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants