Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trackerless-network) [NET-1119]: account for propagation expiration ttl properly #2682

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix(trackerless-network) [NET-1119]: account for propagation expiration ttl properly #2682

merged 1 commit into from
Jul 29, 2024

Conversation

harbu
Copy link
Contributor

@harbu harbu commented Jul 11, 2024 •
edited
Loading

Summary

Filter out expired items in the method FifoMapWithTTL#values otherwise messages older than ttlInMs (30 secs) could be returned.

Checklist before requesting a review

  • Is this a breaking change? If it is, be clear in summary.
  • Read through code myself one more time.
  • Make sure any and all TODO comments left behind are meant to be left in.
  • Has reasonable passing test coverage?
  • Updated changelog if applicable.
  • Updated documentation if applicable.

@linear Linear
Copy link

linear bot commented Jul 11, 2024

NET-1119 trackerless-network: Propagation ignores message expiration

@github-actions github-actions bot added the network Related to Network Package label Jul 11, 2024
@harbu harbu marked this pull request as ready for review July 11, 2024 12:55
@harbu harbu changed the title fix(trackerless-network) [NET-1119]: account for propagation expiration ttl prop… fix(trackerless-network) [NET-1119]: account for propagation expiration ttl properly Jul 11, 2024
@harbu harbu requested a review from juslesan July 11, 2024 13:21
@harbu harbu merged commit 38def11 into main Jul 29, 2024
24 checks passed
@harbu harbu deleted the NET-1119-fix-ttl-expiration-in-propagation branch July 29, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juslesan juslesan juslesan approved these changes

Assignees
No one assigned
Labels
network Related to Network Package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harbu @juslesan