Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(client)[!]: Rename client events #2604

Merged
merged 3 commits into from
Jun 20, 2024
Merged

refactor(client)[!]: Rename client events #2604

merged 3 commits into from
Jun 20, 2024

Conversation

teogeb
Copy link
Contributor

@teogeb teogeb commented Jun 20, 2024 •
edited
Loading

Use naming style of object + verb in past tense:

  • createStream -> streamCreated
  • addToStorageNode -> streamAddedToStorageNode
  • removeFromStorageNode -> streamRemovedFromFromStorageNode

@github-actions github-actions bot added broker Related to Broker Package client Related to Client Package labels Jun 20, 2024
@teogeb teogeb requested a review from harbu June 20, 2024 10:00
@teogeb teogeb changed the title refactor(client): Rename client events refactor(client)[!]: Rename client events Jun 20, 2024
@github-actions github-actions bot added the docs label Jun 20, 2024
@teogeb teogeb merged commit f0a6b6c into main Jun 20, 2024
25 checks passed
@teogeb teogeb deleted the client-event-names branch June 20, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harbu harbu harbu approved these changes

Assignees
No one assigned
Labels
broker Related to Broker Package client Related to Client Package docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teogeb @harbu