-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client, broker): [NET-1310] Use custom event polling logic for Broker features #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
broker
Related to Broker Package
client
Related to Client Package
labels
Jun 18, 2024
teogeb
force-pushed
the
mv-broker-OperatorContractFacade
branch
from
June 18, 2024 12:51
11edbf1
to
35a74cb
Compare
…ork-contracts dependency
harbu
requested changes
Jun 27, 2024
harbu
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
OperatorContractFacade
andoperatorContractUtils
from thebroker
package to theclient
package. Renamed it toOperator
. AddedStreamrClient#getOperator
semi-public method to the client API.Modified the class to use client's contract utilities, e.g. the
FallbackProvider
and theChainEventPoller
.operatorContractUtils
don't useFallbackProvider
and theChainEventPoller
. That's maybe ok as those are used in tests only. But if we start to use the functions in production code, we should start to start to use the helper classes also in these functions.Future improvements
@streamr/network-contracts-ethers6
. But need to find a way to do this without bloating webpack bundle size.@deprecated
?_operatorContractUtils
object? Maybe could add aStreamrClient#getSponsorship
method? Some methods/functions ofOperator
andoperatorContractUtils
could be moved to the class returned by that methodOperatorRegistry
class?Contract
inOperator
?