feat(DHT): Ping neighbors and ring contacts in layer1 #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harbu
approved these changes
Apr 18, 2024
juslesan
added a commit
that referenced
this pull request
Apr 22, 2024
#2502) ## Summary Manually trigger a rejoin to the layer 1 DHTs if connectivity is lost. This is a required feature after #2501 as the nodes in layer1 will lose contacts when disconnected from the internet. This is also an improvement for rejoining streams in general after lost connectivity. This is achieved by reating to a new event the DhtNode that is emitted if the number of neighbors drops to 0 and there are no configured entrypoints. When a layer1 DhtNode emits the event, the network node will attempt to query entry points to a stream from the Layer0 DHT. It will then call `joinDht` on the layer1 node with the queried entry points. This operation is ran in an interval until the node finds at least one neighbor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added configuration to periodically ping neighbors and ring contacts. This ensures that the peers in the nodes' structures are periodically refreshed. This ensures that ungracefully leaving peers are eventually detected.
Changes
Limitations
There needs to be new mechanisms implemented to ensure that nodes that lose connectivity to the internet can rejoin the layer1 DHT. Previously the contacts and nodes in the buckets would remain there if internet connectivity was lost. Nodes will no longer be able to rejoin the streams properly. Publishing this feature before such mechanisms are in place could be detrimental to the system in the long run.