Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: LoggingStaticJsonRpcProvider #2495

Merged
merged 5 commits into from
Apr 10, 2024
Merged

feat: LoggingStaticJsonRpcProvider #2495

merged 5 commits into from
Apr 10, 2024

Conversation

harbu
Copy link
Contributor

@harbu harbu commented Apr 10, 2024 •
edited
Loading

Summary

Create a logging variant of StaticJsonRpcProvider so that we get decent logging of requests and possible errors as well as elapsed time.

Limitations and future improvements

  • Reduce timeout
  • Avoid creating multiple providers per contract

Checklist before requesting a review

  • Is this a breaking change? If it is, be clear in summary.
  • Read through code myself one more time.
  • Make sure any and all TODO comments left behind are meant to be left in.
  • Has reasonable passing test coverage?
  • Updated changelog if applicable.
  • Updated documentation if applicable.

@github-actions github-actions bot added the client Related to Client Package label Apr 10, 2024
@harbu harbu requested a review from teogeb April 10, 2024 08:54
@harbu harbu merged commit 47635ad into main Apr 10, 2024
21 of 23 checks passed
@harbu harbu deleted the logging-static-json-rpc-provider branch April 10, 2024 09:08
@teogeb teogeb mentioned this pull request Jun 10, 2024
Merged
teogeb added a commit that referenced this pull request Jun 10, 2024
@teogeb
refactor(client): Remove obsolete RPC provider options (#2583)
8203cb0 
Removed RPC provider options which were not used. There was regression
in #2495 which removed the
use of these options. Most likely these options aren't currently needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teogeb teogeb teogeb approved these changes

Assignees
No one assigned
Labels
client Related to Client Package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harbu @teogeb