-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client) [NET-1269]: Add support for publishing on behalf of an ERC-1271 contract #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
network
Related to Network Package
client
Related to Client Package
protocol
Related to Protocol Package
dht
Related to DHT package
utils
labels
Mar 11, 2024
This reverts commit 6f6acc8.
harbu
commented
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review with @teogeb , will address these
teogeb
approved these changes
Mar 25, 2024
6 tasks
harbu
added a commit
that referenced
this pull request
Mar 28, 2024
## Summary Subscribe on behalf of an ERC-1271 contract. Follow up to #2423 where we implemented publishing on behalf of an ERC-1271 contract. ### Usage ```ts const client = new StreamrClient({ auth: { privateKey: '<REDACTED>' } }) await client.subscribe({ streamId, erc1271Contract: '0xc0ffee254729296a45a3885639AC7E10F9d54979' }, (msg) => { console.log(msg) }) ``` --------- Co-authored-by: Teo Gebhard <teo@streamr.com>
fonty1
added a commit
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new signature type
ERC_1271
that can be used to publish messages on behalf of a smart contract implementing ERC-1271.Usage
Misc changes
describe.each
in browser test runnerMessageMetadata
interfacegroupKeyId
toMessageMetadata
interfacerecoverSignature
was removed from@streamr/utils
exports. Add back unit tests too.MapWithTtl
to@streamr/utils
. Add unit tests.Limitations and future improvements
instantiateContracts
we could actually injectgetStreamRegistryChainProviders
to even more narrowly abstract the changing factor.Checklist before requesting a review
TODO
comments left behind are meant to be left in.