fix: Fix all hanging tests, reduce flakyness of other tests #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udes a protobuf change. * Bugfix: change gracefulDiconnect into notification (it was previously partly treated as a notification) * Bugfix: do not open new connections when ConnectionManager is in Stopping state * Make timeouts unique by single milliseconds to make it easier to recognize in debug tools which timeout is which * Force SimulatorConnection to send 'disconnect' event in close() the same way as websocket connections * Add constructor option 'stopGivenTransport' DhtNode to indicate that the given transport should not be stopped when the DhtNode is stopped. * Use the 'stopGivenTransport' in trackerless tests (the transports were not previously stopped at all) * Call stop() on simulator in tests if it was started
juslesan
requested changes
Dec 8, 2023
| @@ -68,6 +69,10 @@ describe('inspect', () => { | |||
| Simulator.useFakeTimers(false) | |||
| }) | |||
|
|
|||
| afterAll(() => { | |||
| @@ -32,6 +32,9 @@ export class SimulatorConnector { | |||
| } | |||
|
|
|||
| public connect(targetPeerDescriptor: PeerDescriptor): ManagedConnection { | |||
| if (this.stopped) { | |||
| console.error('connect() called on stopped SimulatorConnector') | |||
teogeb
reviewed
Dec 8, 2023
| @@ -30,7 +30,8 @@ describe('inspect', () => { | |||
| layer0: { | |||
| entryPoints: [publisherDescriptor], | |||
| peerDescriptor, | |||
| transport | |||
| transport, | |||
| stopGivenTransport: true | |||
There was a problem hiding this comment.
Maybe we could use the same pattern as in dht test utils:
network/packages/dht/test/utils/utils.ts
Lines 75 to 76 in e88eaca
Or we could add e.g. stop event which the creator of the instance could listen.
There was a problem hiding this comment.
How about passing a transport factory instead the transport itself?
…m:streamr-dev/network-monorepo into fix-all-dht-and-trackerless-hanging-tests
…m:streamr-dev/network-monorepo into fix-all-dht-and-trackerless-hanging-tests
This was referenced Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all hanging tests. Includes a protobuf change.
Bugfix: change gracefulDiconnect into notification (it was previously partly treated as a notification)
Bugfix: do not open new connections when ConnectionManager is in Stopping state
Make timeouts unique by single milliseconds to make it easier to recognize in debug tools which timeout is which
Force SimulatorConnection to send 'disconnect' event in close() the same way as websocket connections
Add constructor option 'stopGivenTransport' DhtNode to indicate that the given transport should not be stopped when the DhtNode is stopped.
Use the 'stopGivenTransport' in trackerless tests (the transports were not previously stopped at all)
Call stop() on simulator in tests if it was started
remove --force-exit from test scripts
remove memory leaks from client by adding handling of destroy signal to many places and by removing closures
fix mqtt bridge test to properly wait for arriving messages
fix websocket connection establishment in broker websocket plugin test (previously 'error' waitForEvent would time out and cause unhandled promise exception on slower machines)
await for sub1.unsubscribe() in memory leak test to get the subscription to non-random state before testing for memory leaks