Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MQTT-5 topic alias. #688

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Jun 26, 2022

Motivation

Support MQTT-5 topic alias. See specification https://docs.oasis-open.org/mqtt/mqtt/v5.0/mqtt-v5.0.html

Modifications

  • Support topic alias.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@mattisonchao mattisonchao force-pushed the support_topic_alias branch from 51cda34 to 59ec793 Compare June 28, 2022 00:28
@mattisonchao mattisonchao marked this pull request as ready for review June 28, 2022 00:30
@mattisonchao mattisonchao requested review from codelipenghui and a team as code owners June 28, 2022 00:30
@mattisonchao mattisonchao changed the title [WIP] Support topic alias. Support MQTT-5 topic alias. Jun 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #688 (5901bbe) into master (4009d0d) will decrease coverage by 0.95%.
The diff coverage is 36.08%.

❗ Current head 5901bbe differs from pull request most recent head 59ec793. Consider uploading reports for the commit 59ec793 to get more accurate results

@@             Coverage Diff              @@
##             master     #688      +/-   ##
============================================
- Coverage     78.18%   77.22%   -0.96%     
- Complexity      955      964       +9     
============================================
  Files           108      111       +3     
  Lines          4107     4189      +82     
  Branches        309      320      +11     
============================================
+ Hits           3211     3235      +24     
- Misses          725      780      +55     
- Partials        171      174       +3     
Impacted Files Coverage Δ
...exception/MQTTTopicAliasExceedsLimitException.java 0.00% <0.00%> (ø)
...qtt/exception/MQTTTopicAliasNotFoundException.java 0.00% <0.00%> (ø)
...lsar/handlers/mqtt/support/Qos1PublishHandler.java 47.94% <9.52%> (-16.21%) ⬇️
...native/pulsar/handlers/mqtt/TopicAliasManager.java 22.22% <22.22%> (ø)
...ulsar/handlers/mqtt/AbstractQosPublishHandler.java 85.29% <76.19%> (-9.45%) ⬇️
.../streamnative/pulsar/handlers/mqtt/Connection.java 88.75% <100.00%> (+0.14%) ⬆️
...lsar/handlers/mqtt/messages/MqttPropertyUtils.java 90.24% <100.00%> (ø)
...lsar/handlers/mqtt/support/Qos0PublishHandler.java 71.42% <100.00%> (ø)
...ar/handlers/mqtt/utils/PulsarMessageConverter.java 89.91% <100.00%> (+0.74%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4009d0d...59ec793. Read the comment docs.

@Technoboy- Technoboy- merged commit b0ed8ed into streamnative:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants