Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MQTT5-5 publish message expiry interval. #669

Merged

Conversation

Technoboy-
Copy link
Contributor

Master Issue: #369

Motivation

Support MQTT-5 publish message with message expiry interval.

Documentation

  • no-need-doc

@Technoboy- Technoboy- requested review from codelipenghui and a team as code owners June 16, 2022 01:47
@Technoboy- Technoboy- self-assigned this Jun 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #669 (9dffe1b) into master (0d0af93) will increase coverage by 0.26%.
The diff coverage is 72.97%.

@@             Coverage Diff              @@
##             master     #669      +/-   ##
============================================
+ Coverage     77.97%   78.24%   +0.26%     
- Complexity      910      942      +32     
============================================
  Files           108      108              
  Lines          3923     4036     +113     
  Branches        276      305      +29     
============================================
+ Hits           3059     3158      +99     
- Misses          702      710       +8     
- Partials        162      168       +6     
Impacted Files Coverage Δ
...s/mqtt/proxy/MQTTProxyProtocolMethodProcessor.java 77.89% <0.00%> (-0.86%) ⬇️
...lsar/handlers/mqtt/support/Qos1PublishHandler.java 64.81% <0.00%> (ø)
...qtt/support/MQTTBrokerProtocolMethodProcessor.java 78.84% <41.17%> (-0.99%) ⬇️
...handlers/mqtt/restrictions/ClientRestrictions.java 66.66% <80.00%> (ø)
...ar/handlers/mqtt/utils/PulsarMessageConverter.java 89.16% <92.30%> (+3.45%) ⬆️
...lsar/handlers/mqtt/messages/MqttPropertyUtils.java 89.47% <100.00%> (-0.78%) ⬇️
.../pulsar/handlers/mqtt/messages/ack/MqttPubAck.java 87.80% <100.00%> (+0.30%) ⬆️
...ive/pulsar/handlers/mqtt/support/MQTTConsumer.java 97.61% <100.00%> (+0.32%) ⬆️
...e/pulsar/handlers/mqtt/utils/MqttMessageUtils.java 89.88% <100.00%> (+3.73%) ⬆️
...native/pulsar/handlers/mqtt/utils/WillMessage.java 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ec63b...9dffe1b. Read the comment docs.

@Technoboy- Technoboy- merged commit 1b73fbd into streamnative:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants