Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MQTT-5 Publish with user properties. #658

Conversation

Technoboy-
Copy link
Contributor

Motivation

Support send MQTT-5 message with user properties.

Documentation

  • no-need-doc

@Technoboy- Technoboy- requested review from codelipenghui and a team as code owners June 10, 2022 11:38
@Technoboy- Technoboy- self-assigned this Jun 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #658 (ce977c7) into master (0d0af93) will decrease coverage by 0.10%.
The diff coverage is 48.31%.

@@             Coverage Diff              @@
##             master     #658      +/-   ##
============================================
- Coverage     77.97%   77.87%   -0.11%     
- Complexity      910      916       +6     
============================================
  Files           108      108              
  Lines          3923     3950      +27     
  Branches        276      290      +14     
============================================
+ Hits           3059     3076      +17     
- Misses          702      709       +7     
- Partials        162      165       +3     
Impacted Files Coverage Δ
...s/mqtt/proxy/MQTTProxyProtocolMethodProcessor.java 77.89% <0.00%> (-0.86%) ⬇️
...lsar/handlers/mqtt/support/Qos1PublishHandler.java 64.81% <0.00%> (ø)
...qtt/support/MQTTBrokerProtocolMethodProcessor.java 78.84% <41.17%> (-0.99%) ⬇️
...ar/handlers/mqtt/utils/PulsarMessageConverter.java 87.17% <90.90%> (+1.46%) ⬆️
...lsar/handlers/mqtt/messages/MqttPropertyUtils.java 89.47% <100.00%> (-0.78%) ⬇️
.../pulsar/handlers/mqtt/messages/ack/MqttPubAck.java 87.80% <100.00%> (+0.30%) ⬆️
...handlers/mqtt/restrictions/ClientRestrictions.java 68.00% <100.00%> (+1.33%) ⬆️
...pulsar/handlers/mqtt/MQTTCommonInboundHandler.java 77.94% <0.00%> (-4.42%) ⬇️
...e/pulsar/handlers/mqtt/utils/PulsarTopicUtils.java 78.26% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dafac99...ce977c7. Read the comment docs.

@Technoboy- Technoboy- merged commit 818f4b0 into streamnative:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants