fix: 🐛 accept null as value in fromJSON functions
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay, I somehow missed notification about this PR. |
|
🎉 This PR is included in version 2.15.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the
DirectoryJSONalias just to make things easier.I looked at enabled
strictNullChecks, but this package just wasn't designed for it 😂Ideally, it'd be good to have it on at some point, or otherwise ensure all methods that can return
nullorundefinedas thusly typed.I've not linked the issue with this PR, as the issue could be used to track the above, and this is the change that I need ASAP to continue work on my current project.
Once I have some time, I'll be happy to look into making this library more
strictNullCheckscompatible.