Use expects() more appropriately #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have no logical reason to expect that instantiating the DM context will succeed here. We do not treat success as inevitable anywhere else. Signed-off-by: mulhern <amulhern@redhat.com>
"must exist" is almost information free. Signed-off-by: mulhern <amulhern@redhat.com>
|
seems good 👍 |
trgill
approved these changes
Aug 3, 2017
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
May 13, 2020
Add keyfile parameter to pool create
mulkieran
added a commit
that referenced
this pull request
Oct 24, 2021
Add an audit task to the Makefile and to Travis CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
expects()to convey information and if there is no information to convey, turn them intounwraps().rust-lang/rust-clippy#1921 (comment)